Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tdl 17689 breakdown sync method #16

Merged
merged 3 commits into from
Feb 15, 2022
Merged

Tdl 17689 breakdown sync method #16

merged 3 commits into from
Feb 15, 2022

Conversation

prijendev
Copy link
Contributor

@prijendev prijendev commented Feb 8, 2022 •
edited
Loading

Description of change

  • Breakdown sync method to smaller methods for better readability.
  • Passed all existing unit test cases and integration test cases.

Manual QA steps

Risks

Rollback steps

  • revert this branch

@savan-chovatiya savan-chovatiya marked this pull request as ready for review February 9, 2022 03:38
@KrisPersonal KrisPersonal merged commit 3bcf786 into master Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KrisPersonal KrisPersonal KrisPersonal approved these changes

@savan-chovatiya savan-chovatiya savan-chovatiya approved these changes

@karanpanchal-crest karanpanchal-crest Awaiting requested review from karanpanchal-crest

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@prijendev @KrisPersonal @savan-chovatiya